View Issue Detail

ID	Project	Category	Submitted / Last Updated
01032	UserSpice	Misc Code	2020-10-09 15:22:14 / 2020-10-20 03:16:47
Reported	Brandin Arsenault	Assigned To	Unassigned
Priority	low	Reported	5.1.6
Status	closed fixed	Resolution Version and Commit	5.1.7 869e38
Summary	hasPerm improvements
Description	<p>hasPerm has some outdated and redundant code:</p> <p>-add a param to override the default masterAccount behavior </p> <p>-don't global $user twice</p> <p>-move globals into same line</p> <p>-we're returning twice if the id isn't set </p> <p>-we're setting the id twice if it isn't set </p> <p>-we should do one DB query to user_permission_matches and put those in an array called userPerms </p> <p>-do a check for each perm against userPerms, this decides access</p> <p>-$access should be false (not 0) and just return $access at the end </p>

November 2021

Also, it should not require an array if just passing a single perm. A LOOONG time ago this was a multi perm alternative to the checkMenu function, but there's no reason you shouldn't just be able to do if(hasPerm(2)){