View Issue Detail

ID	Project	Category	Submitted / Last Updated
01048	UserSpice	Misc Code	2020-11-02 18:26:43 / 2022-03-12 12:02:46
Reported	Banging Heads	Assigned To	Dan Hoover
Priority	none	Reported	5.1.9
Status	closed	Resolution Version and Commit
Summary	Join/Verify Email coded as nav-items instead of dropdown-items in templates
Description	<p>dbnav.php has hardcoding for join.php & verify_email.php in templates.</p> <p>1st problem would be that they are coded as nav-items instead of dropdown-items in DropdownString.</p> <p> </p> <p>I would like to propose returning nothing if conditions are false, instead of returning something specific if it is true.</p> <p>This would remove the elseifs and make it fall in else in both functions and do an if check and return nothing if it should not be putting the link in the navigation.</p> <p>This solves the problem as they would no longer be hardcoded with an error, as well as not have special conditions to return a specific string.</p> <p> </p> <p>It would end up looking like this:</p> <p>https://gist.github.com/bangingheads/0a16b16dfea72bb3c1ab12336560d6f8</p>

November 2021

<p>Thank you. This is obviously going to require a lot of work and updating/rehashing every template.  Grr. Thanks :)</p>
March 2022

This has finally been resolved and will be the basis of the next generation of templates as well as pushed to the next standard template.