View Issue Detail

ID	Project	Category	Submitted / Last Updated
01080	UserSpice	Misc	2020-12-23 01:34:31 / 2021-03-01 02:31:45
Reported	Andrew Weiner	Assigned To	Unassigned
Priority	none	Reported	5.2.2
Status	closed fixed	Resolution Version and Commit	5.2.3
Summary	Admin area HTML <head> and conditional tags in wrong location.
Description	<p>Hi,</p> <p>The <head> tag on the admin pages is placed after the <title> tags.  HTML requires the <head> tag to be placed immediately after the <!doctype> tag.</p> <p>The file \users\views\_admin_menu.php places the <head> tag after the <title> tag and after the IE test tags.  The <head> tag should be moved directly after the <!doctype> tag.  Also, the Downlevel-hidden conditional coment appears to have extrainous characters which should be removed.</p> <p><code><!--[if gt IE 8]><!--> <html class="no-js" lang=""> <!--<![endif]--></code></p> <p>should be</p> <p><code><!--[if gt IE 8]>      <html class="no-js" lang=""> <![endif]--></code></p> <p>(see modified code below).</p> <p><code><!doctype html></code><br /><code><head></code><br /><code><?php</code><br /><code>$page=currentFile();</code><br /><code>$titleQ = $db->query('SELECT title FROM pages WHERE page = ?', array($page));</code><br /><code>if ($titleQ->count() > 0) {</code><br /><code>    $pageTitle = $titleQ->first()->title;</code><br /><code>}</code><br /><code>else $pageTitle = '';</code><br /><code>?></code><br /><code><title><?= (($pageTitle != '') ? $pageTitle : ''); ?> <?=$settings->site_name?></title></code><br /><code><!--[if lt IE 7]>      <html class="no-js lt-ie9 lt-ie8 lt-ie7" lang=""> <![endif]--></code><br /><code><!--[if IE 7]>         <html class="no-js lt-ie9 lt-ie8" lang=""> <![endif]--></code><br /><code><!--[if IE 8]>         <html class="no-js lt-ie9" lang=""> <![endif]--></code><br /><code><!--[if gt IE 8]>      <html class="no-js" lang=""> <![endif]--></code><br /><code><meta charset="utf-8"><br /> </code><code><meta http-equiv="X-UA-Compatible" content="IE=edge"><br /> <meta name="viewport" content="width=device-width, initial-scale=1, maximum-scale=1"></code></p>

November 2021

<p>This was a perfect bug report. Thank you!</p>
November 2021

<p>Thanks Andrew!</p>