View Issue Detail

ID	Project	Category	Submitted / Last Updated
01129	UserSpice	Plugins	2021-02-02 16:12:59 / 2021-03-01 02:31:45
Reported	Mark Z	Assigned To	Unassigned
Priority	none	Reported	5.2.3
Status	closed fixed	Resolution Version and Commit	5.2.5
Summary	Google social login bug
Description	It installed correctly, I edited the keys in the admin panel, the button shows up in the login page, you click and go to google page to login and then when it returns you to the US site you are not logged in. If you go to the login page again the google login button has dissapeared. Once you log in with normal email and logout, then the google login button appears again. Here are some php errors that might help: Attempt to assign property &#039;isNewAccount&#039; of non-object \| file:/users/classes/User.php \| ln:248 Trying to get property &#039;id&#039; of non-object \| file:/usersc/plugins/google_login/assets/google_oauth.php \| ln:88

November 2021

What I found (running 5.2.3): 1) Column "created" is missing in the users table and is needed in user.php class: $insert = $this->_db->query("INSERT INTO $this->tableName SET password = NULL,username = '".$username."',active = '".$active."',oauth_provider = '".$oauth_provider."', oauth_uid = '".$oauth_uid."',permissions = '".$active."', email_verified = '".$active."', fname = '".$fname."', lname = '".$lname."', email = '".$email."', picture = '".$picture."', gpluslink = '".$link."', join_date = '".date('Y-m-d H:i:s')."',created = '".date('Y-m-d H:i:s')."', modified = '".date('Y-m-d H:i:s')."'") or die('Google oAuth Error'); 2) Also on user.php class: if ($foundUS == 1) {                 //Found an existing UserSpice user with the same email                 // die("user already has userspice");                 $this->_db->query('UPDATE users WHERE id = 3 SET lname = ?', [$email]) or die('Google oAuth Error'); Why is id=3 hardcoded? I believe, this messes things up if the user already exists
November 2021

Thanks Mark