View Issue Detail

ID	Project	Category	Submitted / Last Updated
01217	UserSpice	Triage	2021-05-02 05:20:51 / 2021-05-02 20:15:14
Reported	Mark Z	Assigned To	Unassigned
Priority	none	Reported	5.2.4
Status	closed	Resolution Version and Commit
Summary	Number of logins in db not counted correctly
Description	If a user signs up, doesn't click on the verification link on his email but rather try to log in he is presented with the "We were unable to verify your account. Please try again" and a resubmit verification email etc.. But that attempt is captured on the users->logins db entry so it might end up showing X logins while he actualy has never successfully logged in. Is this the expected behaviour of the "logins" db entry? Or should it count only successful logins? (after the user has verified the account)

November 2021

While I understand the concern that exists, there is a successful login in the way the flow is designed. After a user logs in, init.php handles redirecting the user to the verification page if required.
November 2021

But the user is not actually logged in if he hasn't verified the email address because he can't access any Private pages. He can access public pages, but he would be able to do that even if he wasn't logged in either... What is the purpose of counting that as a successful login then? Where is this info actually useful, apart from showing that as a number on the user's account page?