View Issue Detail

ID	Project	Category	Submitted / Last Updated
01300	UserSpice	Misc Code	2021-08-19 17:59:45 / 2021-11-20 10:16:23
Reported	Rich Morgan	Assigned To	Unassigned
Priority	low	Reported	5.3.4
Status	closed	Resolution Version and Commit
Summary	fetchUserDetails Function
Description	It seems that this function, located in users/helpers/users.php, doesn't operate as described in the documentation. The function accepts 3 parameters, either the combination of the first and second parameters <column name> and <value>, or the third parameter <id>. The examples given are.. For an ID lookup: fetchUserDetails(null,null,1); For a username lookup: fetchUserDetails('username','admin'); For an email lookup: fetchUserDetails('email','bob@aol.com');? This is the current function.. function fetchUserDetails($username = null, $token = null, $id = null){ $db = DB::getInstance(); $column = $data = $results = null; if ($username != null) { $column = 'username'; $data = $username; } elseif ($id != null) { $column = 'id'; $data = $id; } if (!is_null($column) && !is_null($data)) { $query = $db->query("SELECT * FROM users WHERE $column = ? LIMIT 1", [$data]); if ($query->count() == 1) { $results = $query->first(); } } return $results; } The current function seems to only allow the first parameter to be a username, not 'email' or any other column. I think it could be updated to something like this.... function fetchUserDetails($column = null, $token = null, $id = null){ $db = DB::getInstance(); $data = $results = null; if ($column != null) { $data = $token; } elseif ($id != null) { $column = 'id'; $data = $id; } if (!is_null($column) && !is_null($data)) { $query = $db->query("SELECT * FROM users WHERE $column = ? LIMIT 1", [$data]); if ($query->count() == 1) { $results = $query->first(); } } return $results; }

November 2021

The documentation is outdated. We need to consider updating the function to allow email, and amending the documentation as well. However, the first and third work as expected.
November 2021

There were two tickets on this. I simplified the function so you can still pass just an id (awkwardly as the 3rd argument) or any column and any value as the first and second arguments and the function will work as the documentation states. There is also a simpler fetchUser($id) function where you just pass an id with no other parameters. Closing as duplicate for changelog purposes, even though this ticket was first. Much appreciated Rich. Thanks for your support.