View Issue Detail

ID	Project	Category	Submitted / Last Updated
01412	UserSpice	ACP Code	2021-11-21 19:03:52 / 2021-12-26 01:48:40
Reported	Mio Ussum	Assigned To	Unassigned
Priority	none	Reported	5.3.7
Status	closed fixed	Resolution Version and Commit	5.3.8
Summary	Warnings from createAttempt hook
Description	In users\views\_admin_users.php a hook with the position createAttempt is handled. However, such a hook position is not supported in the getMyHooks function in users\helpers\us_helpers.php. This results in some warnings inside includeHook on line 1168, because it is trying to iterate $hooks['createAttempt'] which never gets added to the $hooks array. You can see the warnings for a brief moment (before the redirect happens) after submitting the addUser modal window form inside the admin dashboard.

November 2021

This issue is caused by the getMyHooks not recognizing the createAttempt position. Preferred solution is to remove the if statements and just pass the position that is defined by the user (and if none, return null)
November 2021

I don't really want to do that because it requires plugin developers to research all the various positions we could put out there. All event hooks use the body position. I think the preferred solution is to pass body as default when registering and using event hooks so we can obscure that and avoid confusion. Event hooks are events so they don't really need "position"