View Issue Detail

ID	Project	Category	Submitted / Last Updated
01429	UserSpice	Triage	2021-12-09 17:27:02 / 2021-12-26 01:48:40
Reported	Marc J	Assigned To	Unassigned
Priority	none	Reported	5.3.8
Status	closed fixed	Resolution Version and Commit	5.3.9
Summary	Emails with a '+' in them fail verification
Description	+ is a valid email character, used a lot by gmail users who want to use site-specific unique email addresses (see https://support.google.com/a/users/answer/9308648?hl=en). If a registration email address contains a + character, it enters OK, the email arrives, and the verification link seems OK, but it fails at the verification stage.

December 2021

This is being caused by not url encoding the email address, the plus sign turns into a space then you no longer have a valid email/matching email address. _email_template_verify.php line 15: <p><a href="<?=$results->verify_url?>users/verify.php?email=<?=$email;?>&vericode=<?=$vericode;?>" class="nounderline"><?=lang("EML_VER")?></a></p> We need to url encode the $email variable. Since it is part of the query urlencode() is the proper function. <p><a href="<?=$results->verify_url?>users/verify.php?email=<?=urlencode($email);?>&vericode=<?=$vericode;?>" class="nounderline"><?=lang("EML_VER")?></a></p>