View Issue Detail

ID	Project	Category	Submitted / Last Updated
01434	UserSpice	Misc	2021-12-12 10:36:01 / 2022-02-01 06:42:28
Reported	Dan Hoover	Assigned To	Unassigned
Priority	none	Reported	5.3.8
Status	stalled	Resolution Version and Commit
Summary	Add a migration to delete the install folder
Description

December 2021

or rename 2020-07-06 $countE=0; function delete_files($target) { if(is_dir($target)){ $files = glob( $target . '*', GLOB_MARK ); //GLOB_MARK adds a slash to directories returned foreach( $files as $file ){ delete_files( $file ); } rmdir( $target ); } elseif(is_file($target)) { unlink( $target ); } } delete_files($abs_us_root.$us_url_root.'install/');if($countE==0) { $db->insert('updates',['migration'=>$update]); if(!$db->error()) { if($db->count()>0) { logger(1,"System Updates","Update $update successfully deployed."); $successes[] = "Update $update successfully deployed."; } else { logger(1,"System Updates","Update $update unable to be marked complete, query was successful but no database entry was made."); $errors[] = "Update ".$update." unable to be marked complete, query was successful but no database entry was made."; } } else { $error=$db->errorString(); logger(1,"System Updates","Update $update unable to be marked complete, Error: ".$error); $errors[] = "Update $update unable to be marked complete, Error: ".$error; } } else { logger(1,"System Updates","Update $update unable to be marked complete"); $errors[] = "Update $update unable to be marked complete"; }
December 2021

Should we REALLY do this? What if a user has re-created the install directory for another purpose in their installation, or didn't want the installer removed for whatever reason? I cautious us to be deleting files in users install, especially since we don't have an "optional" migration feature yet, only a skip which needs to be explicitly performed prior to migrations running.