View Issue Detail

ID	Project	Category	Submitted / Last Updated
01502	UserSpice	Templates	2022-04-15 12:34:11 / 2022-04-15 17:27:58
Reported	Daniel Yantis	Assigned To	Unassigned
Priority	none	Reported	5.4.1
Status	stalled	Resolution Version and Commit
Summary	html_footer.php and usersc/templates/standard/footer.php suggested fix
Description	users/_blank_pages/project_root.php users/init.php users/includes/template/prep.php -Page Code Here users/includes/html_footer.php html_footer.php then includes: usersc/includes/templates/standard/footer.php that then includes: users/includes/html_footer.php html_footer.php should have container_close.php and page_footer.php then is should have the user footer.php then close body and html as it is now html_footer seems to call itself in the user footer. my thinking on this is that prep.php opens &lt;head&gt; then &lt;/head&gt; and then opens &lt;body&gt; then container_open.php html_footer.php is the closing of all that. you currently have the user footer.php calling container_close.php and page_footer.php then html_footer.php and then again it calls the user footer.php AGAIN

April 2022

I do agree that the HTML footer should be encompassing of all of this, but the reason it was designed the way it is, is so that templates can better manage how these items are injected into their styling. If we remove a templates ability to change/omit the container_close and the page_footer, we make it harder for template developers. While what you're suggesting might logically make sense, in the current state of the project and how we put the templates together, it won't work.
April 2022

i guess container_open then should be called somewhere other than prep.php but ok. it doesn't hurt anything as is.