View Issue Detail

ID	Project	Category	Submitted / Last Updated
00558	UserSpice	Misc Code	2019-05-02 02:21:31 / 2019-06-19 21:16:06
Reported	Faguss PL	Assigned To	Unassigned
Priority	normal	Reported	4.4.10
Status	closed fixed	Resolution Version and Commit	4.4.14 63f8c6
Summary	hasPerm optimization
Description	<p>Function hasPerm is making multiple queries instead of just one. To fix replace lines 897-906 in file users\helpers\us_helpers.php with this:</p> <p><code>        if (count($permissions)>0){</code><br /><br /><code>            if ($access == 0){</code><br /><code>                $query = $db->query("SELECT id FROM user_permission_matches  WHERE user_id = ? AND permission_id IN (".substr(str_repeat(",?",count($permissions)),1).")", array_merge([$id],$permissions));</code><br /><code>                $results = $query->count();</code><br /><code>                if ($results > 0){</code><br /><code>                    $access = 1;</code><br /><code>                }</code><br /><code>            }</code><br /><code>        }</code></p> <p> </p>

November 2021

Replace condition <code>count($permissions)>0</code> with<code></code> <code>!empty($permissions)</code> <code></code>
November 2021

Thanks for this Faguss.  I'm planning this for .12
November 2021

The performance checker shows this method to be pretty consistently slower for some reason. Not sure why.
November 2021

I've tested it the following way: <code>$before = microtime(true);</code> <code>for ($i=0 ; $i<1000 ; $i++)</code> <code>    hasPerm([100,101,102,103,104,105,106,107,108,109,110],100);</code> <code>$after = microtime(true);</code> <code>echo ($after-$before) . " sec/hasPerm\n";</code> And it's 1.04 for original and 0.1 for new.
November 2021

Performance would be increased by reducing the number of queries-but substituting an equal for a IN is where the concern came when I was reviewing the statement. We should look into why the performance checker thinks the adjustment is slower. It is fine to implement this fix.