View Issue Detail

ID	Project	Category	Submitted / Last Updated
00686	UserSpice	Misc	2019-08-28 18:43:47 / 2020-07-22 20:05:52
Reported	Albert Gukasian	Assigned To	Unassigned
Priority	none	Reported	4.4.14
Status	closed fixed	Resolution Version and Commit
Summary	Redundant check in header.php
Description	<p><span style="font-family: monospace;">//if track_guest enabled AND there is a user logged in</span></p> <p><span style="font-family: monospace;">if($settings->track_guest == 1 && $user->isLoggedIn()){</span></p> <p><span style="font-family: monospace;"> if ($user->isLoggedIn()){</span></p> <p><span style="font-family: monospace;"> $user_id=$user->data()->id;</span></p> <p><span style="font-family: monospace;"> }else{</span></p> <p><span style="font-family: monospace;"> $user_id=0;</span></p> <p><span style="font-family: monospace;"> }</span></p> <p><span style="font-family: monospace;"> new_user_online($user_id);</span></p> <p><span style="font-family: monospace;">}</span></p> <p> </p> <p><span style="font-family: monospace;">Checks </span><span style="font-family: monospace;">$user->isLoggedIn() twice.</span></p> <p>File users\includes\header.php line:84</p>

November 2021

<p>Thanks for reporting this. This was fixed in 5.0. Since it's not causing any issues, it won't be patched in 4.4 unless we have to push out a security patch. </p>